Issue 10837127: Make code follow the Python style guidelines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837127: Make code follow the Python style guidelines (Closed)

Created:
8 years, 4 months ago by jackpal

Modified:
8 years, 4 months ago

Reviewers:
ahe, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/

Visibility:
Public.

More Reviews

Description

Make code follow the Python style guidelines + Use a doc string for the whole file. + Lower case function names. + Consistently use single-quotes for quoted strings. + align wrapped elements with opening delimiter. + use a main() function Committed: https://code.google.com/p/dart/source/detail?r=10307

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	bleeding_edge/dart/tools/gyp_dart.py	View	1	1 chunk	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jackpal

Here's a CL that fixes the Python style problems that ahe reported in http://codereview.chromium.org/10836101

8 years, 4 months ago (2012-08-06 20:09:17 UTC) #1

ahe

8 years, 4 months ago (2012-08-21 20:48:31 UTC) #3

Hi Jack,

LGTM

Catching up...

In the meantime I discovered yet another style guide... sheesh.

Seems like the style you used originally is what we're supposed to do. Sorry for
causing confusion.

Cheers,
Peter

Expand Messages | Collapse Messages