Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 10837047: Disable C++ exceptions in std libraries on Windows (Closed)

Created:
8 years, 4 months ago by Søren Gjesse
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable C++ exceptions in std libraries on Windows As Dart C++ code cannot use C++ exceptions make sure that the C++ libraries on Windows does not try to use C++ exceptions. This gets rid of the warning warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc when compiling on Windows. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=10167

Patch Set 1 #

Patch Set 2 : Moved setting to MSVC configuration file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gyp/configurations_msvs.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
8 years, 4 months ago (2012-08-01 13:39:37 UTC) #1
Søren Gjesse
Moved setting to MSVC configuration file.
8 years, 4 months ago (2012-08-02 13:30:30 UTC) #2
Mads Ager (google)
8 years, 4 months ago (2012-08-02 13:32:04 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698