Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10837025: Properly emit variable declarations. (Closed)

Created:
8 years, 4 months ago by Anton Muhin
Modified:
8 years, 4 months ago
Reviewers:
Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly emit variable declarations. VariableElements share definition in VarialbleListElement, so it should be only output once. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10082

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M lib/compiler/implementation/dart_backend/emitter.dart View 1 2 chunks +11 lines, -2 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 5 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anton Muhin
8 years, 4 months ago (2012-07-31 17:57:53 UTC) #1
Roman
lgtm https://chromiumcodereview.appspot.com/10837025/diff/1/lib/compiler/implementation/dart_backend/emitter.dart File lib/compiler/implementation/dart_backend/emitter.dart (right): https://chromiumcodereview.appspot.com/10837025/diff/1/lib/compiler/implementation/dart_backend/emitter.dart#newcode74 lib/compiler/implementation/dart_backend/emitter.dart:74: if (!processedVariableLists.contains(variableList)) { Hmm, I just thought about ...
8 years, 4 months ago (2012-07-31 18:45:03 UTC) #2
Anton Muhin
8 years, 4 months ago (2012-07-31 18:55:37 UTC) #3
https://chromiumcodereview.appspot.com/10837025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10837025/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/emitter.dart:74: if
(!processedVariableLists.contains(variableList)) {
Good point, todo added.

On 2012/07/31 18:45:03, Roman wrote:
> Hmm, I just thought about it in another way - we output the whole list of
> defined variables, even the ones we don't need, right?
> Maybe a TODO to fix it? (you may assign it to me if you want) Although the fix
> will probably require some duplication of unparser code

Powered by Google App Engine
This is Rietveld 408576698