Issue 10837017: Refactor prettyprinter, keep track of currently opened nodes,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837017: Refactor prettyprinter, keep track of currently opened nodes, (Closed)

Created:
8 years, 4 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor prettyprinter, keep track of currently opened nodes, output begin and end token for all nodes. Committed: https://code.google.com/p/dart/source/detail?r=10049

Patch Set 4 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -60 lines)			Patch
	M	lib/compiler/implementation/tree/prettyprint.dart	View	1 2 3	16 chunks	+74 lines, -60 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10837017/diff/3002/lib/compiler/implementation/tree/prettyprint.dart File lib/compiler/implementation/tree/prettyprint.dart (right): https://chromiumcodereview.appspot.com/10837017/diff/3002/lib/compiler/implementation/tree/prettyprint.dart#newcode20 lib/compiler/implementation/tree/prettyprint.dart:20: /** Nodes that were opened with [openNodoe()] calls. ...

8 years, 4 months ago (2012-07-31 09:35:27 UTC) #2

Roman

8 years, 4 months ago (2012-07-31 10:08:34 UTC) #3

https://chromiumcodereview.appspot.com/10837017/diff/3002/lib/compiler/implem...
File lib/compiler/implementation/tree/prettyprint.dart (right):

https://chromiumcodereview.appspot.com/10837017/diff/3002/lib/compiler/implem...
lib/compiler/implementation/tree/prettyprint.dart:20: /** Nodes that were opened
with [openNodoe()] calls. */
On 2012/07/31 09:35:27, Anton Mukhin wrote:
> nit: openNode

Done.

https://chromiumcodereview.appspot.com/10837017/diff/3002/lib/compiler/implem...
lib/compiler/implementation/tree/prettyprint.dart:58: if (params == null) params
= new Map();
On 2012/07/31 09:35:27, Anton Mukhin wrote:
> nit: ===

Done.

Expand Messages | Collapse Messages

Issue 10837017: Refactor prettyprinter, keep track of currently opened nodes, (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages