Process private identifier in visitIdentifier.

Process private identifier in visitIdentifier.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=11128

[Roman, 2012-08-21 16:01:35]

On 2012/08/21 15:38:23, Anton Muhin wrote:

This looks very nice. But I'm not sure that's what we want. I'm almost sure that
with this change we will have 2 placeholders for one node. Example:
method() {
  var _f = 5;
  _f;
}

Now it depends on what we rename first - private identifiers or locals. We won't
even break here, because currently we don't rename locals at all, and there will
be only one identifier _f in top scope. What about this example:
method1() {
  var _f = 5;
  _f;
}

method2() {
  var _f = 6;
  _f;
}


Also I wonder what happens if there's private class _A defined:
class _A {}
main() {
  new _A();
  _A.somestatic;
  _A.somestaticmethod();
  var a = new _A();
  (a as _A);
  var _A = 5;
}

It is difficult to test this, because we can't create conflicting _A in another
library and try to import it to force renames, we get unresolved error
immediately.

It would be much clearer with minifier, but there are still about 20 tests that
just fail.

[Roman, 2012-08-22 08:56:21]

lgtm