Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10836355: Make sure that libraries loaded from dart:core gets dart:core implicitly loaded. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)
Modified:
8 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make sure that libraries loaded from dart:core gets dart:core implicitly loaded. This is in preparation for deprecating the corelib Math object in favor of the dart:math library. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11032

Patch Set 1 #

Patch Set 2 : Fix mock compiler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M lib/compiler/implementation/compiler.dart View 1 2 chunks +12 lines, -11 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 1 1 chunk +4 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 5 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mads Ager (google)
8 years, 4 months ago (2012-08-21 08:52:00 UTC) #1
ahe
I expect one test failure from this. Did you run the tests? LGTM
8 years, 4 months ago (2012-08-21 08:58:02 UTC) #2
Mads Ager (google)
I did run the tests, yes. Not in host-checked mode though. I will do that ...
8 years, 4 months ago (2012-08-21 09:00:45 UTC) #3
Mads Ager (google)
Ah, there were quite a few tests that I didn't run. I have a bunch ...
8 years, 4 months ago (2012-08-21 09:03:53 UTC) #4
Mads Ager (google)
Fixed mock compiler. Please have another look?
8 years, 4 months ago (2012-08-21 11:08:51 UTC) #5
ahe
8 years, 4 months ago (2012-08-21 11:21:04 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698