Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 10836339: Get rid of the name in HInvokeDynamic (just use the selector instead). (Closed)

Created:
8 years, 4 months ago by kasperl
Modified:
8 years, 4 months ago
Reviewers:
karlklose, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of the name in HInvokeDynamic (just use the selector instead). This fixes issue 2620. R=ngeoffray@google.com,karlklose@google.com BUG=http://dartbug.com/2620 Committed: https://code.google.com/p/dart/source/detail?r=11030

Patch Set 1 #

Patch Set 2 : Fix long line. Update comment. #

Patch Set 3 : Fix compound assignments. #

Patch Set 4 : Fix checked mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -77 lines) Patch
M lib/compiler/implementation/js_backend/backend.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/resolver.dart View 1 2 3 3 chunks +12 lines, -6 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 2 7 chunks +34 lines, -22 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 2 5 chunks +14 lines, -17 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 1 2 2 chunks +17 lines, -22 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/compound_assignment_operator_test.dart View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 4 months ago (2012-08-20 13:58:20 UTC) #1
ngeoffray
LGTM!
8 years, 4 months ago (2012-08-20 14:13:26 UTC) #2
karlklose
8 years, 4 months ago (2012-08-20 14:15:38 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698