Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10836312: Add a couple of workarounds for issues caused by current dart2js patch (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a couple of workarounds for issues caused by current dart2js patch support. R=johnniwinther@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10878

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M lib/compiler/implementation/elements/elements.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/dartdoc/mirrors/dart2js_mirror.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
This change let't me patch in static methods without getting into trouble with dart2js nor ...
8 years, 4 months ago (2012-08-17 10:24:27 UTC) #1
Johnni Winther
LGTM with comments https://chromiumcodereview.appspot.com/10836312/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10836312/diff/1/lib/compiler/implementation/resolver.dart#newcode163 lib/compiler/implementation/resolver.dart:163: // [interface] is an interface, let's ...
8 years, 4 months ago (2012-08-17 10:39:45 UTC) #2
Mads Ager (google)
8 years, 4 months ago (2012-08-17 10:44:38 UTC) #3
Thanks Johnni.

https://chromiumcodereview.appspot.com/10836312/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10836312/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:163: // [interface] is an interface,
let's say "MyInterface".
On 2012/08/17 10:39:45, Johnni Winther wrote:
> [intrface] refers to the local variable so we should probably use the name in
> the comment.

Reverted this change. What a horrible variable name. ;-)

https://chromiumcodereview.appspot.com/10836312/diff/1/pkg/dartdoc/mirrors/da...
File pkg/dartdoc/mirrors/dart2js_mirror.dart (right):

https://chromiumcodereview.appspot.com/10836312/diff/1/pkg/dartdoc/mirrors/da...
pkg/dartdoc/mirrors/dart2js_mirror.dart:1313: }
On 2012/08/17 10:39:45, Johnni Winther wrote:
> This will make dartdoc show patch code. I would prefer if we could instead
> obtain the span from the original element.

I agree with you. I will let you do that. This is just a gross hack so I can
continue working. :-)

Powered by Google App Engine
This is Rietveld 408576698