Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 10836289: Update status file for dummy_compiler. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
ricow1, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status file for dummy_compiler. Committed: https://code.google.com/p/dart/source/detail?r=10828

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review comments and then some #

Patch Set 3 : Address one more comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M dart/tests/utils/utils.status View 1 2 1 chunk +4 lines, -26 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 4 months ago (2012-08-16 14:11:55 UTC) #1
kasperl
LGTM.
8 years, 4 months ago (2012-08-16 14:13:12 UTC) #2
ricow1
LGTM (sorry for not combining those in my last commit) https://chromiumcodereview.appspot.com/10836289/diff/1/dart/tests/utils/utils.status File dart/tests/utils/utils.status (left): https://chromiumcodereview.appspot.com/10836289/diff/1/dart/tests/utils/utils.status#oldcode43 ...
8 years, 4 months ago (2012-08-16 14:13:53 UTC) #3
ahe
PTAL https://chromiumcodereview.appspot.com/10836289/diff/1/dart/tests/utils/utils.status File dart/tests/utils/utils.status (left): https://chromiumcodereview.appspot.com/10836289/diff/1/dart/tests/utils/utils.status#oldcode43 dart/tests/utils/utils.status:43: [ $compiler == frog && $runtime == none ...
8 years, 4 months ago (2012-08-16 15:54:59 UTC) #4
ricow1
8 years, 4 months ago (2012-08-16 16:07:15 UTC) #5
Looks really good to me

https://chromiumcodereview.appspot.com/10836289/diff/4003/dart/tests/utils/ut...
File dart/tests/utils/utils.status (right):

https://chromiumcodereview.appspot.com/10836289/diff/4003/dart/tests/utils/ut...
dart/tests/utils/utils.status:5: dartdoc_test: Fail # http://dartbug.com/4540
I like this way better, we will actually notice when it gets fixed then

Powered by Google App Engine
This is Rietveld 408576698