Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 10836272: Move status file entries from tests/lib to pkg so as not to run known failing tests on the moved li… (Closed)

Created:
8 years, 4 months ago by Alan Knight
Modified:
8 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move status file entries from tests/lib to pkg so as not to run known failing tests on the moved li… Committed: https://code.google.com/p/dart/source/detail?r=10772

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M pkg/pkg.status View 1 1 chunk +17 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
8 years, 4 months ago (2012-08-15 21:42:45 UTC) #1
Emily Fortuna
https://chromiumcodereview.appspot.com/10836272/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://chromiumcodereview.appspot.com/10836272/diff/1/pkg/pkg.status#newcode17 pkg/pkg.status:17: [ $compiler == dart2js || $compiler == dartc || ...
8 years, 4 months ago (2012-08-15 21:46:19 UTC) #2
Alan Knight
Made fixes, had also missed one that's now added. https://chromiumcodereview.appspot.com/10836272/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://chromiumcodereview.appspot.com/10836272/diff/1/pkg/pkg.status#newcode17 pkg/pkg.status:17: ...
8 years, 4 months ago (2012-08-15 21:50:42 UTC) #3
Emily Fortuna
8 years, 4 months ago (2012-08-15 22:00:15 UTC) #4
lgtm!

Powered by Google App Engine
This is Rietveld 408576698