Change indexed load and store IL instructions to fit with SSA backend.

Change indexed load and store IL instructions to fit with SSA backend.

Generic indexed operations are implemented as normal instance calls. Specialized
operations are inserted by the flow-graph optimizer. This also avoid a lot of duplicated code
in the code generator.
Committed: https://code.google.com/p/dart/source/detail?r=10727

[Vyacheslav Egorov (Google), 2012-08-15 13:16:09]

lgtm with comments

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_builder.cc
File vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_builder....
vm/flow_graph_builder.cc:2111: false));  // Result not needed.
It's not the first place where we pass boolean as a resultnot needed indicator.
Consider instroducing enum and fixing all call sites to make them more readable.

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_optimize...
File vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_optimize...
vm/flow_graph_optimizer.cc:196: case kImmutableArrayCid:
I don't think StoreIndexedComp correctly handles store into immutable array.
VisitStoreIndexed did not specialize for it.

[Florian Schneider, 2012-08-15 13:53:51]

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_builder.cc
File vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_builder....
vm/flow_graph_builder.cc:2111: false));  // Result not needed.
On 2012/08/15 13:16:09, Vyacheslav Egorov (Google) wrote:
> It's not the first place where we pass boolean as a resultnot needed
indicator.
> Consider instroducing enum and fixing all call sites to make them more
readable.

Since there is only two very localized call-sites per helper in this case, I
don't see how an enum is much more readable.

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_optimize...
File vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10836239/diff/1/vm/flow_graph_optimize...
vm/flow_graph_optimizer.cc:196: case kImmutableArrayCid:
On 2012/08/15 13:16:09, Vyacheslav Egorov (Google) wrote:
> I don't think StoreIndexedComp correctly handles store into immutable array.
> VisitStoreIndexed did not specialize for it.

Thanks for the catch. Done.

[srdjan, 2012-08-15 22:13:34]

Nice! DBC:

https://chromiumcodereview.appspot.com/10836239/diff/8001/vm/flow_graph_optim...
File vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10836239/diff/8001/vm/flow_graph_optim...
vm/flow_graph_optimizer.cc:203: if (op_kind == Token::kINDEX) {
Assert somewhere that you have only Token::INDEX or Token::ASSIGN_INDEX