Issue 10836006: Rename MathNatives_2atan to MathNatives_atan2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836006: Rename MathNatives_2atan to MathNatives_atan2. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google), William Hesse, Mads Ager (chromium)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Rename MathNatives_2atan to MathNatives_atan2. The comment doesn't appear to be valid anymore. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10012

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -5 lines)			Patch
M	runtime/lib/math.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/lib/math.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (google)

LGTM, where have you tested this? I wonder if this was only a problem on ...

8 years, 4 months ago (2012-07-30 13:06:26 UTC) #2

Anders Johnsen

8 years, 4 months ago (2012-07-30 13:25:37 UTC) #3

Only Linux for now, but I was hoping we could do that and see if it breaks
anything. Preparing for revert... :)