Issue 10834426: Support general serializing of functions between JS and Dart

Issue 10834426: Support general serializing of functions between JS and Dart (Closed)

Created:
8 years, 4 months ago by vsm

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support general serializing of functions between JS and Dart Anton: This expands on your earlier CL. Do you mind taking a look? Committed: https://code.google.com/p/dart/source/detail?r=11066

Patch Set 2 : Fix long lines #

Total comments: 4

Patch Set 3 : Address review comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -25 lines)			Patch
M	client/dart.js	View	1	2 chunks	+30 lines, -0 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		7 chunks	+39 lines, -7 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		7 chunks	+39 lines, -7 lines	0 comments	Download
M	lib/html/src/Isolates.dart	View	1 2	3 chunks	+29 lines, -0 lines	0 comments	Download
M	lib/isolate/serialization.dart	View		4 chunks	+10 lines, -7 lines	0 comments	Download
M	tests/html/js_interop_func_passing_test.dart	View		1 chunk	+62 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10834426/diff/2001/lib/html/src/Isolates.dart File lib/html/src/Isolates.dart (right): https://chromiumcodereview.appspot.com/10834426/diff/2001/lib/html/src/Isolates.dart#newcode125 lib/html/src/Isolates.dart:125: var f = ([arg0 = _UNSPECIFIED, arg1 = ...

8 years, 4 months ago (2012-08-21 11:27:35 UTC) #2

vsm

8 years, 4 months ago (2012-08-21 15:59:26 UTC) #3

Thanks!  Landing.

https://chromiumcodereview.appspot.com/10834426/diff/2001/lib/html/src/Isolat...
File lib/html/src/Isolates.dart (right):

https://chromiumcodereview.appspot.com/10834426/diff/2001/lib/html/src/Isolat...
lib/html/src/Isolates.dart:125: var f = ([arg0 = _UNSPECIFIED, arg1 =
_UNSPECIFIED,
On 2012/08/21 11:27:35, Anton Muhin wrote:
> nit: I'd not introduce f local and would just return function expression, but
I
> know I favour too much terse syntax.

Done.

https://chromiumcodereview.appspot.com/10834426/diff/2001/lib/html/src/Isolat...
lib/html/src/Isolates.dart:129: if (last >= 0) args.removeRange(last,
args.length - 1);
On 2012/08/21 11:27:35, Anton Muhin wrote:
> getRange(0, last) is slightly more readable, but YMMV

Done.

Expand Messages | Collapse Messages