Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10834363: Install a signal handler to ensure drt-trampoline.py cleans up after itself. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Install a signal handler to ensure drt-trampoline.py cleans up after itself. Committed: https://code.google.com/p/dart/source/detail?r=10840

Patch Set 1 #

Patch Set 2 : Add a few comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M dart/tools/testing/drt-trampoline.py View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
8 years, 4 months ago (2012-08-16 16:17:30 UTC) #1
Bill Hesse
lgtm
8 years, 4 months ago (2012-08-16 16:21:14 UTC) #2
Bill Hesse
On 2012/08/16 16:21:14, Bill Hesse wrote: > lgtm BUG=dart:4541 TEST=pub/...
8 years, 4 months ago (2012-08-16 16:22:17 UTC) #3
ahe
On 2012/08/16 16:22:17, Bill Hesse wrote: > BUG=dart:4541 That bug is unrelated. > TEST=pub/... I ...
8 years, 4 months ago (2012-08-16 16:32:23 UTC) #4
Emily Fortuna
lgtm
8 years, 4 months ago (2012-08-16 16:59:48 UTC) #5
ahe
8 years, 4 months ago (2012-08-16 17:03:12 UTC) #6
Thank you, Bill and Emily.

I added a few comments to explain why we are interested in those signals. I'll
submit it now, and revert if it doesn't work on Windows.

Cheers,
Peter

Powered by Google App Engine
This is Rietveld 408576698