Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 10834353: Reapply "Sharing of sources for corelib date implementation between VM (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Sharing of sources for corelib date implementation between VM and dart2js". BUG= Committed: https://code.google.com/p/dart/source/detail?r=10799

Patch Set 1 #

Patch Set 2 : Fix analyzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1093 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M corelib/src/implementation/corelib_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + corelib/src/implementation/date.dart View 4 chunks +8 lines, -5 lines 0 comments Download
D corelib/unified/core/date.dart View 1 chunk +0 lines, -217 lines 0 comments Download
D corelib/unified/core/implementation/date.dart View 1 chunk +0 lines, -181 lines 0 comments Download
M lib/compiler/implementation/lib/core.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/coreimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/coreimpl_patch.dart View 1 chunk +7 lines, -0 lines 0 comments Download
D runtime/lib/date.dart View 1 chunk +0 lines, -492 lines 0 comments Download
A + runtime/lib/date_patch.dart View 9 chunks +27 lines, -192 lines 0 comments Download
M runtime/lib/lib_impl_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
Only change is to ignore 'external' constructors in the same way as redirecting constructors in ...
8 years, 4 months ago (2012-08-16 07:57:41 UTC) #1
Mads Ager (google)
On 2012/08/16 07:57:41, Mads Ager wrote: > Only change is to ignore 'external' constructors in ...
8 years, 4 months ago (2012-08-16 07:59:18 UTC) #2
Anders Johnsen
LGTM
8 years, 4 months ago (2012-08-16 07:59:28 UTC) #3
scheglov
8 years, 4 months ago (2012-08-16 12:29:03 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698