Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 10834343: Fix access to fields that didn't exist in the class. (Closed)

Created:
8 years, 4 months ago by floitsch
Modified:
8 years, 4 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix access to fields that didn't exist in the class. Say we have class A{} class B extends A { var x; } and somewhere: new A().x; Then we would see if there was only one field 'x' in the whole type-hierarchy (including B), but we failed to verify that the field was accessible from A. Committed: https://code.google.com/p/dart/source/detail?r=10841

Patch Set 1 #

Patch Set 2 : Fix type annotation. #

Total comments: 2

Patch Set 3 : Address comment. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M lib/compiler/implementation/world.dart View 1 2 3 2 chunks +14 lines, -15 lines 0 comments Download
A + tests/language/cast2_test.dart View 1 2 1 chunk +23 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 4 months ago (2012-08-15 21:48:05 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/10834343/diff/2001/tests/language/cast2_test.dart File tests/language/cast2_test.dart (right): https://chromiumcodereview.appspot.com/10834343/diff/2001/tests/language/cast2_test.dart#newcode1 tests/language/cast2_test.dart:1: // Test created from multitest named /home/floitsch/code/dart_green/dart/tests/language/cast_test.dart. Long ...
8 years, 4 months ago (2012-08-16 12:49:05 UTC) #2
floitsch
8 years, 4 months ago (2012-08-16 14:21:42 UTC) #3
https://chromiumcodereview.appspot.com/10834343/diff/2001/tests/language/cast...
File tests/language/cast2_test.dart (right):

https://chromiumcodereview.appspot.com/10834343/diff/2001/tests/language/cast...
tests/language/cast2_test.dart:1: // Test created from multitest named
/home/floitsch/code/dart_green/dart/tests/language/cast_test.dart.
On 2012/08/16 12:49:05, kasperl wrote:
> Long line. Do we have to have that here?

No. This is just an artifact of copying the original cast test.
done.

Powered by Google App Engine
This is Rietveld 408576698