Issue 10834331: Move the shared arrays and string_buffer files to where they belong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834331: Move the shared arrays and string_buffer files to where they belong. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move the shared arrays and string_buffer files to where they belong. R=ajohnsen@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10728

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -182 lines)			Patch
A +	corelib/src/implementation/arrays.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	corelib/src/implementation/corelib_impl_sources.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	corelib/src/implementation/string_buffer.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl.dart	View	1 chunk	+2 lines, -3 lines	1 comment	Download
D	runtime/lib/arrays.dart	View	1 chunk	+0 lines, -93 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	runtime/lib/string_buffer.dart	View	1 chunk	+0 lines, -86 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, no change needed for editor/analyzer? https://chromiumcodereview.appspot.com/10834331/diff/1/lib/compiler/implementation/lib/coreimpl.dart File lib/compiler/implementation/lib/coreimpl.dart (right): https://chromiumcodereview.appspot.com/10834331/diff/1/lib/compiler/implementation/lib/coreimpl.dart#newcode22 lib/compiler/implementation/lib/coreimpl.dart:22: #source('../../../../corelib/src/implementation/arrays.dart'); This is ...

8 years, 4 months ago (2012-08-15 13:55:01 UTC) #2

Mads Ager (google)

8 years, 4 months ago (2012-08-15 13:56:44 UTC) #3

On 2012/08/15 13:55:01, ajohnsen wrote:
> LGTM, no change needed for editor/analyzer?

No change should be needed since the create_sdk script should deal with this
without issues (copy the files from the new location).

Expand Messages | Collapse Messages