Initial implementation of 'Create Method' quick fix

Initial implementation of 'Create Method' quick fix

 - only top-level functions are supported;
 - argument suggestions are not bound to the linked nodes, just first suggestion is used.

2. Tweak for resolved AST access


R=messick@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10468

[messick, 2012-08-08 14:34:36]

https://chromiumcodereview.appspot.com/10834222/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java
(right):

https://chromiumcodereview.appspot.com/10834222/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java:94:
// we don't want to spend too much time on resolving here.
I'm a little confused by this comment. Refactoring runs at user-interaction
speeds. Why can't we ensure we have a resolved AST? The alternative is
unreproducible bug reports, or inconsistent behavior.

https://chromiumcodereview.appspot.com/10834222/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java:99:
//        // see bug 63554
We don't have bug 63554 (yet)

[scheglov, 2012-08-08 15:41:05]

https://chromiumcodereview.appspot.com/10834222/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java
(right):

https://chromiumcodereview.appspot.com/10834222/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java:94:
// we don't want to spend too much time on resolving here.
On 2012/08/08 14:34:37, messick wrote:
> I'm a little confused by this comment. Refactoring runs at user-interaction
> speeds. Why can't we ensure we have a resolved AST? The alternative is
> unreproducible bug reports, or inconsistent behavior.

Well, clients should be prepared, that AST is not resolved, not all nodes have
elements, etc.
This just may happen by other reasons.
And the worst what will happen - you will not see some Quick Assist or Quick
Fix.

But we can try to do better.
I've changed ASTProvider to provide actually resolved AST.

https://chromiumcodereview.appspot.com/10834222/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/AssistContext.java:99:
//        // see bug 63554
On 2012/08/08 14:34:37, messick wrote:
> We don't have bug 63554 (yet)

Done.