Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 10834216: Correctly disable BadNumberFormatException test for dartc and dart2js. (Closed)

Created:
8 years, 4 months ago by Bob Nystrom
Modified:
8 years, 4 months ago
Reviewers:
ahe, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correctly disable BadNumberFormatException test for dartc and dart2js. Committed: https://code.google.com/p/dart/source/detail?r=10360

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/co19/co19-compiler.status View 1 2 chunks +1 line, -2 lines 0 comments Download
M tests/co19/co19-leg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Alrighty, let me try that again...
8 years, 4 months ago (2012-08-07 21:46:02 UTC) #1
Emily Fortuna
ah yes, not specifying a category for the failing tests is not useful. :-P (I ...
8 years, 4 months ago (2012-08-07 21:48:00 UTC) #2
Bob Nystrom
8 years, 4 months ago (2012-08-07 21:52:19 UTC) #3
Thanks!

https://chromiumcodereview.appspot.com/10834216/diff/1/tests/co19/co19-compil...
File tests/co19/co19-compiler.status (right):

https://chromiumcodereview.appspot.com/10834216/diff/1/tests/co19/co19-compil...
tests/co19/co19-compiler.status:6: 
On 2012/08/07 21:48:00, Emily Fortuna wrote:
> remove whitespace line here.

Done.

Powered by Google App Engine
This is Rietveld 408576698