Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10834155: Reapply "Use platform-independent format specifiers when disassembling code objects." (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)
Modified:
8 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Use platform-independent format specifiers when disassembling code objects." This reapplies svn revision 10163 with a (tested) fix for Windows. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -43 lines) Patch
M runtime/include/dart_api.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/platform/globals.h View 2 chunks +17 lines, -7 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +22 lines, -28 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
Tested to compile on Windows.
8 years, 4 months ago (2012-08-03 14:36:21 UTC) #1
Florian Schneider
8 years, 4 months ago (2012-08-06 08:53:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698