Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 10834098: Fix issue 4227 - unittest.dart silently consumes exceptions when expectAsync is active. (Closed)

Created:
8 years, 4 months ago by gram
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 4227 - unittest.dart silently consumes exceptions when expectAsync is active. Committed: https://code.google.com/p/dart/source/detail?r=10103

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M lib/unittest/unittest.dart View 1 1 chunk +1 line, -0 lines 1 comment Download
M tests/lib/unittest/unittest_test.dart View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
8 years, 4 months ago (2012-07-31 23:34:49 UTC) #1
Siggi Cherem (dart-lang)
http://codereview.chromium.org/10834098/diff/2001/lib/unittest/unittest.dart File lib/unittest/unittest.dart (right): http://codereview.chromium.org/10834098/diff/2001/lib/unittest/unittest.dart#newcode725 lib/unittest/unittest.dart:725: _nextTestCase(); I'm thinking more about this, and I don't ...
8 years, 4 months ago (2012-08-01 00:11:16 UTC) #2
Siggi Cherem (dart-lang)
8 years, 4 months ago (2012-08-01 00:45:43 UTC) #3
lgtm. Good point, I am not sure if we already had the problem.

I think the problem can be solved, though. We would need to keep track on
guardAsync which test it is being guarded. In that sense, it should only mark as
failing that test (and not look at the 'current' test).

Powered by Google App Engine
This is Rietveld 408576698