Added Dart_FunctionEnclosingClassOrLibrary.

Added Dart_FunctionEnclosingClassOrLibrary.
Committed: https://code.google.com/p/dart/source/detail?r=10096

[turnidge, 2012-07-31 22:22:07]

lgtm, with one small comment.

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/include/dart_a...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/include/dart_a...
runtime/include/dart_api.h:2076: * library (if it is a top-level function or a
closure defined in such).
can you split the description into a short first sentence and then a second
paragraph with the details?

1st sentence: Returns a handle to the enclosing class or library for a function.

2nd paragraph: If this function is a blah, then....

Note that in this file we say a "handle to" instead of a "handle on"

[rmacnak, 2012-07-31 22:27:41]

Updated comment language.

On 2012/07/31 22:22:07, turnidge wrote:
> lgtm, with one small comment.
> 
>
https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/include/dart_a...
> File runtime/include/dart_api.h (right):
> 
>
https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/include/dart_a...
> runtime/include/dart_api.h:2076: * library (if it is a top-level function or a
> closure defined in such).
> can you split the description into a short first sentence and then a second
> paragraph with the details?
> 
> 1st sentence: Returns a handle to the enclosing class or library for a
function.
> 
> 2nd paragraph: If this function is a blah, then....
> 
> Note that in this file we say a "handle to" instead of a "handle on"

[Ivan Posva, 2012-07-31 23:38:58]

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2794: }
if (func.IsError()) {
  return function;
}

[rmacnak, 2012-08-01 17:21:55]

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2794: }
If I add that test with an ASSERT(false), that path isn't taken even for error
cases like the argument being an error handle, an integer handle, or the null
handle. Same story in Dart_FunctionName (one function up).

On 2012/07/31 23:38:58, Ivan Posva wrote:
> if (func.IsError()) {
>   return function;
> }

[turnidge, 2012-08-01 17:59:42]

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2794: }
Checking for an error handle isn't required here.  It is already done by the
combination of UnwrapFunctionHandle + RETURN_TYPE_ERROR.

[Ivan Posva, 2012-08-01 20:43:55]

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10834096/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2794: }
On 2012/08/01 17:59:42, turnidge wrote:
> Checking for an error handle isn't required here.  It is already done by the
> combination of UnwrapFunctionHandle + RETURN_TYPE_ERROR.

Thanks for the clarification. The difference between UnwrapTypeHandle and
UnwrapHandle is very subtle and could lead to a lot of missed checks. But that
discussion does not belong into this CL review.