Issue 10834065: Revert https://chromiumcodereview.appspot.com/10789012/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834065: Revert https://chromiumcodereview.appspot.com/10789012/ (Closed)

Created:
8 years, 4 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert https://chromiumcodereview.appspot.com/10789012/ We now use default class for ClassElement Committed: https://code.google.com/p/dart/source/detail?r=10041

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
M	lib/compiler/implementation/dart_backend/emitter.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 4 months ago (2012-08-02 17:47:08 UTC) #3

LGTM

Thank you for reverting this. I'm not keen on having more than one AST node in
the elements. I think my TODO is obsolete, but I need to think about it.

Expand Messages | Collapse Messages