Added InterfaceMirror.newInstance().

Added InterfaceMirror.newInstance().
Committed: https://code.google.com/p/dart/source/detail?r=10020

[rmacnak, 2012-07-30 16:33:45]

https://chromiumcodereview.appspot.com/10834056/diff/3002/lib/mirrors/mirrors...
File lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/10834056/diff/3002/lib/mirrors/mirrors...
lib/mirrors/mirrors.dart:275: Future<InstanceMirror> newInstance(String
constructorName,
newInstance is somewhat misleading as a Dart constructor need not return a newly
allocated object. Perhaps invokeConstructor?

[Ivan Posva, 2012-07-30 17:03:28]

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/10834056/diff/3002/lib/mirrors/mirrors...
File lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/10834056/diff/3002/lib/mirrors/mirrors...
lib/mirrors/mirrors.dart:275: Future<InstanceMirror> newInstance(String
constructorName,
On 2012/07/30 16:33:45, Ryan Macnak wrote:
> newInstance is somewhat misleading as a Dart constructor need not return a
newly
> allocated object. Perhaps invokeConstructor?

The same "confusion" can happen in non-mirrored Dart as well:
var x = new Foo();

The instance assigned to x could have been around for a very long time already.
I would leave the name as is so that it matches the language construct. With
invokeConstructor I personally would expect that I need to allocate the object
first before calling the constructor.

https://chromiumcodereview.appspot.com/10834056/diff/3002/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10834056/diff/3002/runtime/lib/mirrors...
runtime/lib/mirrors.cc:913: Dart_Handle raw_invoke_args =
Dart_GetNativeArgument(args, 2);
I know that you are following the precedent set in other code in this file. Raw
has a very special meaning within the VM, please choose a better name together
with Todd.

https://chromiumcodereview.appspot.com/10834056/diff/3002/tests/lib/mirrors/m...
File tests/lib/mirrors/mirrors_test.dart (right):

https://chromiumcodereview.appspot.com/10834056/diff/3002/tests/lib/mirrors/m...
tests/lib/mirrors/mirrors_test.dart:73: expect(instance is Class, equals(true));
Please make sure that the correct constructor was called by setting a value in
the field.

[rmacnak, 2012-07-30 17:48:22]

https://chromiumcodereview.appspot.com/10834056/diff/3002/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10834056/diff/3002/runtime/lib/mirrors...
runtime/lib/mirrors.cc:913: Dart_Handle raw_invoke_args =
Dart_GetNativeArgument(args, 2);
For now I switched to 'wrapped_args' to agree with their being passed to
UnwrapArgList. I'll talk with Todd about switching the other uses of 'raw' in
the file.

On 2012/07/30 17:03:28, Ivan Posva wrote:
> I know that you are following the precedent set in other code in this file.
Raw
> has a very special meaning within the VM, please choose a better name together
> with Todd.

https://chromiumcodereview.appspot.com/10834056/diff/3002/tests/lib/mirrors/m...
File tests/lib/mirrors/mirrors_test.dart (right):

https://chromiumcodereview.appspot.com/10834056/diff/3002/tests/lib/mirrors/m...
tests/lib/mirrors/mirrors_test.dart:73: expect(instance is Class, equals(true));
Done.

On 2012/07/30 17:03:28, Ivan Posva wrote:
> Please make sure that the correct constructor was called by setting a value in
> the field.