Issue 10833068: Refactor building arguments for InstanceCall and fix deoptimization environment for pushed argument…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833068: Refactor building arguments for InstanceCall and fix deoptimization environment for pushed argument… (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Refactor building arguments for InstanceCall and fix deoptimization environment for pushed arguments. This CL enables SSA compilation of functions containing InstanceCallComp computations. It also contains a bug fix to correctly simulate the deoptimization environment for argument expressions. Committed: https://code.google.com/p/dart/source/detail?r=10011

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -100 lines)			Patch
M	vm/flow_graph_builder.cc	View	1	7 chunks	+36 lines, -18 lines	0 comments	Download
M	vm/flow_graph_optimizer.cc	View		8 chunks	+29 lines, -16 lines	0 comments	Download
M	vm/il_printer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	vm/intermediate_language.h	View		20 chunks	+58 lines, -35 lines	0 comments	Download
M	vm/intermediate_language.cc	View		4 chunks	+22 lines, -28 lines	0 comments	Download
M	vm/intermediate_language_ia32.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	vm/intermediate_language_x64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10833068/diff/1/vm/flow_graph_builder.cc File vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10833068/diff/1/vm/flow_graph_builder.cc#newcode1435 vm/flow_graph_builder.cc:1435: int length = node->arguments()->length(); const int length

8 years, 4 months ago (2012-07-30 13:17:58 UTC) #2

Florian Schneider

8 years, 4 months ago (2012-07-30 13:26:14 UTC) #3

https://chromiumcodereview.appspot.com/10833068/diff/1/vm/flow_graph_builder.cc
File vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10833068/diff/1/vm/flow_graph_builder....
vm/flow_graph_builder.cc:1435: int length = node->arguments()->length();
On 2012/07/30 13:17:58, Vyacheslav Egorov (Google) wrote:
> const int length

Done.

Expand Messages | Collapse Messages