Issue 10832436: Remove most references to frog from lib/compiler .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832436: Remove most references to frog from lib/compiler . (Closed)

Created:
8 years, 4 months ago by dgrove

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove most references to frog from lib/compiler . Committed: https://code.google.com/p/dart/source/detail?r=11115

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -28 lines)			Patch
M	lib/compiler/implementation/README.txt	View	1 chunk	+4 lines, -17 lines	0 comments	Download
M	lib/compiler/implementation/lib/interceptors.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/script.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/tools/find_file_to_parse.sh	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

I'm not sure about the change to use MockFile as a type annotation. Take a ...

8 years, 4 months ago (2012-08-21 23:04:13 UTC) #2

dgrove

8 years, 4 months ago (2012-08-21 23:59:52 UTC) #3

On 2012/08/21 23:04:13, ahe wrote:
> I'm not sure about the change to use MockFile as a type annotation. 
> 
> Take a look at http://code.google.com/p/dart/wiki/TestingDart2js, in
particular
> running dummy_compiler_test. If that works with dart2js_developer, you're
fine. 
> 
> With that caveat: LGTM
> 
> And thank you for keeping it neat!
> 
> Cheers,
> Peter

You're correct, Peter. I've reverted that part of this change, and corrected the
comment to point to the dart2js parser_helper.

Expand Messages | Collapse Messages