Issue 10832411: Remove support for non-ssa optimizing code generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832411: Remove support for non-ssa optimizing code generation. (Closed)

Created:
8 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 4 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove support for non-ssa optimizing code generation. This kills FrameRegisterAllocator and related code. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11045

Patch Set 2 : disable optimizations on bailout #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -489 lines)			Patch
M	runtime/vm/compiler.cc	View	1	9 chunks	+37 lines, -32 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+5 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		3 chunks	+0 lines, -82 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		16 chunks	+21 lines, -130 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View		6 chunks	+4 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		5 chunks	+7 lines, -21 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View		6 chunks	+4 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		5 chunks	+7 lines, -22 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		4 chunks	+3 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		4 chunks	+58 lines, -69 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		14 chunks	+15 lines, -40 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		14 chunks	+15 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

https://chromiumcodereview.appspot.com/10832411/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10832411/diff/1/runtime/vm/compiler.cc#newcode398 runtime/vm/compiler.cc:398: CompileParsedFunctionHelper(parsed_function, optimized); When bailing out, we should mark the ...

8 years, 4 months ago (2012-08-21 12:50:01 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 10832411: Remove support for non-ssa optimizing code generation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : disable optimizations on bailout #

Messages