Issue 10832380: Don't shortcut if we're trying to get the latest copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832380: Don't shortcut if we're trying to get the latest copy. (Closed)

Created:
8 years, 4 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't shortcut if we're trying to get the latest copy. Committed: https://code.google.com/p/dart/source/detail?r=10926

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/get_archive.py	View		1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 4 months ago (2012-08-20 15:24:45 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10832380/diff/1/tools/get_archive.py
File tools/get_archive.py (right):

https://chromiumcodereview.appspot.com/10832380/diff/1/tools/get_archive.py#n...
tools/get_archive.py:308: if args.revision and args.revision < 4285:
Consider keeping a table of latest revisions keyed by name at the top.  Then you
could hoist these checks once as:

if args.revision and args.revision < LAST_VALID[positional[0]]:
  ...

Expand Messages | Collapse Messages