Issue 4544. Report only unit URI, without URI of library.

Issue 4544. Report only unit URI, without URI of library.
http://code.google.com/p/dart/issues/detail?id=4544


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10921

[Brian Wilkerson, 2012-08-17 17:52:50]

https://chromiumcodereview.appspot.com/10832372/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/UrlDartSource.java (right):

https://chromiumcodereview.appspot.com/10832372/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/UrlDartSource.java:40: public String
getName() {
I think I tried to get this change made once before and was told that this would
break dartc's ability to differentiate between a single compilation unit when
compiled in the context of two different libraries. I then tried to remove the
assumptions about the URI format and found that they ran fairly deep. I think
the safest way to fix this issue (maybe the only safe way) is to change the code
that formats error messages for output.

[scheglov, 2012-08-17 20:33:41]

https://chromiumcodereview.appspot.com/10832372/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/UrlDartSource.java (right):

https://chromiumcodereview.appspot.com/10832372/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/UrlDartSource.java:40: public String
getName() {
On 2012/08/17 17:52:50, Brian Wilkerson wrote:
> I think I tried to get this change made once before and was told that this
would
> break dartc's ability to differentiate between a single compilation unit when
> compiled in the context of two different libraries. I then tried to remove the
> assumptions about the URI format and found that they ran fairly deep. I think
> the safest way to fix this issue (maybe the only safe way) is to change the
code
> that formats error messages for output.

Done.

[Brian Wilkerson, 2012-08-17 20:34:29]

LGTM

https://chromiumcodereview.appspot.com/10832372/diff/3/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java (right):

https://chromiumcodereview.appspot.com/10832372/diff/3/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year