Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 108323002: Add tests for clearing a field (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master
Visibility:
Public.

Description

Add tests for clearing a field This tests the change to the protobuf library in https://chromiumcodereview.appspot.com/106663007/. R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/314b57f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M test/message_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years ago (2013-12-06 14:45:42 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years ago (2013-12-09 18:27:27 UTC) #2
Søren Gjesse
7 years ago (2013-12-10 07:36:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r314b57f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698