Issue 10832291: Add missing abort on duplicate class fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832291: Add missing abort on duplicate class fields. (Closed)

Created:
8 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add missing abort on duplicate class fields. Committed: https://code.google.com/p/dart/source/detail?r=10626

Patch Set 2 : Added TODOs at duplicate cancels. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -27 lines)			Patch
	M	lib/compiler/implementation/elements/elements.dart	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
	M	tests/co19/co19-leg.status	View		5 chunks	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://chromiumcodereview.appspot.com/10832291/diff/1/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10832291/diff/1/lib/compiler/implementation/elements/elements.dart#newcode1036 lib/compiler/implementation/elements/elements.dart:1036: listener.cancel('existing definition', token: existing.position()); What's the right way to ...

8 years, 4 months ago (2012-08-14 10:28:24 UTC) #1

LGTM (if you add the TODO we discussed)

Expand Messages | Collapse Messages

Issue 10832291: Add missing abort on duplicate class fields. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added TODOs at duplicate cancels. #

Messages