Issue 10832283: Allow non-const field initializers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832283: Allow non-const field initializers (Closed)

Created:
8 years, 4 months ago by hausner

Modified:
8 years, 4 months ago

Reviewers:
srdjan, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow non-const field initializers Revision 0.11 of the spec allows arbitrary initializer expressions for instance fields. Issue 3848 Committed: https://code.google.com/p/dart/source/detail?r=10672

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -61 lines)			Patch
M	runtime/vm/parser.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	6 chunks	+49 lines, -60 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

8 years, 4 months ago (2012-08-24 15:39:22 UTC) #5

I was surprised too that we have no tests :-)

I wish that we had a policy that every new language feature (or language change)
should come with a set of tests that are expected to pass once the feature is
implemented.

Before I checked in this change, I played around with a few simple, one-off
cases to make sure it does what I expect. I rely on more extensive co19 tests
for full test coverage.

Expand Messages | Collapse Messages