Issue 10832277: Eliminate condition type check when possible.

Issue 10832277: Eliminate condition type check when possible. (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate condition type check when possible. Committed: https://code.google.com/p/dart/source/detail?r=10610

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -42 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+24 lines, -3 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	5 chunks	+20 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+17 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+17 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediate_language.h#newcode469 runtime/vm/intermediate_language.h:469: bool IsEliminated() const { s/IsEliminated/is_eliminated_. https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediate_language.h#newcode472 runtime/vm/intermediate_language.h:472: void ...

8 years, 4 months ago (2012-08-13 22:14:18 UTC) #2

regis

8 years, 4 months ago (2012-08-13 22:23:49 UTC) #3

Thanks

I applied the same renaming for AssertAssignableComp.

-- Regis

https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:469: bool IsEliminated() const {
On 2012/08/13 22:14:18, srdjan wrote:
> s/IsEliminated/is_eliminated_.

Done.

https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:472: void Eliminate() {
On 2012/08/13 22:14:18, srdjan wrote:
> s/Eliminate/eliminate/

Done.

https://chromiumcodereview.appspot.com/10832277/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:484: bool eliminated_;
On 2012/08/13 22:14:18, srdjan wrote:
> s/eliminated_/is_eleminated_/

Done.

Expand Messages | Collapse Messages