Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 10832274: Initial parser changes for the new directive syntax (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson
Modified:
8 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial parser changes for the new directive syntax Committed: https://code.google.com/p/dart/source/detail?r=10599

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -148 lines) Patch
M compiler/java/com/google/dart/compiler/ast/ASTVisitor.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartImportDirective.java View 1 chunk +32 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartLibraryDirective.java View 1 chunk +19 lines, -3 lines 0 comments Download
A compiler/java/com/google/dart/compiler/ast/DartPartOfDirective.java View 1 chunk +34 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java View 1 chunk +36 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/ImportHideCombinator.java View 4 chunks +7 lines, -14 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/ImportShowCombinator.java View 4 chunks +7 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java View 1 chunk +8 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 13 chunks +152 lines, -44 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartPrefixParser.java View 1 2 chunks +16 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java View 1 chunk +0 lines, -14 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Library.java View 4 chunks +15 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyDescriptorHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java View 1 4 chunks +12 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartModelManager.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/ImportRewriteAnalyzer.java View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Wilkerson
8 years, 4 months ago (2012-08-13 19:43:39 UTC) #1
scheglov
8 years, 4 months ago (2012-08-13 19:58:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698