Add an OutputStream.closed getter.

Add an OutputStream.closed getter.

BUG=3603
Committed: https://code.google.com/p/dart/source/detail?r=10455

[nweiz, 2012-08-07 20:43:27]

Contrary to bug 3603, I didn't cause OutputStream.close() to throw an exception
if the stream is already closed. That's not how InputStream behaves, so I
figured that if that behavior was going to be changed it should be changed for
both interfaces at once.

[Søren Gjesse, 2012-08-08 11:49:15]

lgtm

https://chromiumcodereview.appspot.com/10832188/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/StringBuffer.dart
(right):

https://chromiumcodereview.appspot.com/10832188/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/StringBuffer.dart:88: final
bool closed = false;
Accidental edit?

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_server_socket_test.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_server_socket_test.dart:37: bool get closed() =>
_socket._closed;
Not strictly needed here. It is never used and ExpectedDataOutputStream is
already missing other methods from OutputStream.

[Bill Hesse, 2012-08-08 12:46:01]

Let me take a look - there are some tricky semantics about close(), closed(),
and onClosed() that I want to get right.

[Bill Hesse, 2012-08-08 14:21:11]

LGTM.

https://chromiumcodereview.appspot.com/10832188/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/StringBuffer.dart
(right):

https://chromiumcodereview.appspot.com/10832188/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/StringBuffer.dart:88: final
bool closed = false;
On 2012/08/08 11:49:15, Søren Gjesse wrote:
> Accidental edit?

No, this needs to be there, and is correct.  Maybe close() should throw an
unsupported exceptions, though.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:217: 
This will all need some work if we want writes after close() to throw
exceptions, instead of calling onError, but it is working as it was previously
this way, so OK.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:223: } else if (!_closeCallbackCalled) {
Call this _closeCallbackScheduled.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:272: (_onNoPendingWrites != null)) {
Extra parentheses.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:291: // When this is set to true the close callback
has been called and
Change the comment and the name to closeCallbackScheduled.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/list_strea...
File runtime/bin/list_stream_impl.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/list_strea...
runtime/bin/list_stream_impl.dart:129: if (!_bufferList.isEmpty() &&
I don't like the idea that we aren't sending onData messages after we have
closed the ListOutputStream.  But this is a pre-existing bug.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
File runtime/bin/output_stream.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:39: * by the output stream and will be sent as
soon as possible.
I think that the write functions should throw an immediate exception if the
stream is closed, not call onError.  But this is a separate change, and I will
do this.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:61: * Indicate that all data has been written to
the output
"Signal that no more data will be written to the output stream.  When all
buffered data has been written out to
the communication channel, the channel will be closed and
the onClosed callback will be called."

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:74: * Returns whether the stream is closed. No
more data may be written to a
Returns whether the stream has been closed by calling close().   If true, no
more data may be written to the output stream, but there still may be buffered
data that has not been written to the communication channel.  The onClosed
handler will only be called once all data has been written out.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:89: * communication channel has been closed and
no more data can be
has been closed and all the buffered data has been sent.

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/fi...
File tests/standalone/io/file_output_stream_test.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/fi...
tests/standalone/io/file_output_stream_test.dart:26: Expect.isTrue(x.closed);
This is different from an InputStream, where we want closed() to be true only
after the onClosed handler has been called, I think.

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/fi...
tests/standalone/io/file_output_stream_test.dart:26: Expect.isTrue(x.closed);
Should you test that write() throws an exception here?

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/li...
File tests/standalone/io/list_output_stream_test.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/li...
tests/standalone/io/list_output_stream_test.dart:148:
Expect.isTrue(stream.closed);
Why not check the contents here?

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/li...
tests/standalone/io/list_output_stream_test.dart:157: 
Add a test that .write throws an exception here?

[nweiz, 2012-08-09 19:39:52]

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:223: } else if (!_closeCallbackCalled) {
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Call this _closeCallbackScheduled.

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:272: (_onNoPendingWrites != null)) {
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Extra parentheses.

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:291: // When this is set to true the close callback
has been called and
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Change the comment and the name to closeCallbackScheduled.

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
File runtime/bin/output_stream.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:61: * Indicate that all data has been written to
the output
On 2012/08/08 14:21:11, Bill Hesse wrote:
> "Signal that no more data will be written to the output stream.  When all
> buffered data has been written out to
> the communication channel, the channel will be closed and
> the onClosed callback will be called."

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:74: * Returns whether the stream is closed. No
more data may be written to a
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Returns whether the stream has been closed by calling close().   If true, no
> more data may be written to the output stream, but there still may be buffered
> data that has not been written to the communication channel.  The onClosed
> handler will only be called once all data has been written out.

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/runtime/bin/output_str...
runtime/bin/output_stream.dart:89: * communication channel has been closed and
no more data can be
On 2012/08/08 14:21:11, Bill Hesse wrote:
> has been closed and all the buffered data has been sent.

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/fi...
File tests/standalone/io/file_output_stream_test.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/fi...
tests/standalone/io/file_output_stream_test.dart:26: Expect.isTrue(x.closed);
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Should you test that write() throws an exception here?

Yes, but currently it would fail that test due to a bug in _FileOutputStream
that's unrelated to this change.

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_server_socket_test.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_server_socket_test.dart:37: bool get closed() =>
_socket._closed;
On 2012/08/08 11:49:15, Søren Gjesse wrote:
> Not strictly needed here. It is never used and ExpectedDataOutputStream is
> already missing other methods from OutputStream.

Removed.

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/li...
File tests/standalone/io/list_output_stream_test.dart (right):

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/li...
tests/standalone/io/list_output_stream_test.dart:148:
Expect.isTrue(stream.closed);
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Why not check the contents here?

Done.

https://chromiumcodereview.appspot.com/10832188/diff/1/tests/standalone/io/li...
tests/standalone/io/list_output_stream_test.dart:157: 
On 2012/08/08 14:21:11, Bill Hesse wrote:
> Add a test that .write throws an exception here?

Done.