Issue 10832150: Get rid of ast node ids.

Issue 10832150: Get rid of ast node ids. (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Get rid of ast node ids. Rename cid to deopt_id. Committed: https://code.google.com/p/dart/source/detail?r=10306

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+366 lines, -451 lines)			Patch
M	runtime/vm/ast.h	View	1	6 chunks	+1 line, -28 lines	0 comments	Download
M	runtime/vm/ast_printer.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/code_descriptors.h	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/code_descriptors.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	9 chunks	+32 lines, -37 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/debugger.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/debugger.cc	View	1	7 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	8 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1	6 chunks	+9 lines, -14 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	23 chunks	+25 lines, -35 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1	6 chunks	+10 lines, -15 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	23 chunks	+25 lines, -35 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	15 chunks	+20 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	44 chunks	+56 lines, -56 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	44 chunks	+56 lines, -56 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1	2 chunks	+12 lines, -10 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	runtime/vm/object.h	View	1	9 chunks	+15 lines, -16 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	11 chunks	+29 lines, -29 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	11 chunks	+8 lines, -26 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM! Thanks for the cleanup. https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/code_descriptors.h File runtime/vm/code_descriptors.h (right): https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/code_descriptors.h#newcode19 runtime/vm/code_descriptors.h:19: intptr_t deopt_id; // AST ...

8 years, 4 months ago (2012-08-04 00:53:25 UTC) #2

regis

8 years, 4 months ago (2012-08-06 19:51:44 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/code_descri...
File runtime/vm/code_descriptors.h (right):

https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/code_descri...
runtime/vm/code_descriptors.h:19: intptr_t deopt_id;          // AST node id.
On 2012/08/04 00:53:25, srdjan wrote:
> s/AST node id/Deoptimization id/

Done.

https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/isolate.h#n...
runtime/vm/isolate.h:177: static const intptr_t kNoDeoptId = -1;
On 2012/08/04 00:53:25, srdjan wrote:
> Weird indentation.

Done.

https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/isolate.h#n...
runtime/vm/isolate.h:179: void set_deopt_id(int value) { deopt_id_ = value; }
On 2012/08/04 00:53:25, srdjan wrote:
> ASSERT(value >= 0);

Done.

https://chromiumcodereview.appspot.com/10832150/diff/1/runtime/vm/isolate.h#n...
runtime/vm/isolate.h:180: intptr_t GetNextDeoptId() { return deopt_id_++; }
On 2012/08/04 00:53:25, srdjan wrote:
> ASSERT(deopt_id != kNoDeoptId);

Done.

Expand Messages | Collapse Messages