Issue 10832149: Update script to switch through revision history successfully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832149: Update script to switch through revision history successfully. (Closed)

Created:
8 years, 4 months ago by Emily Fortuna

Modified:
8 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update script to switch through revision history successfully. Committed: https://code.google.com/p/dart/source/detail?r=10271

Patch Set 1 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -97 lines)			Patch
M	tools/get_archive.py	View	8 chunks	+32 lines, -25 lines	2 comments	Download
M	tools/testing/perf_testing/run_perf_tests.py	View	25 chunks	+128 lines, -71 lines	0 comments	Download
M	tools/testing/webdriver_test_setup.py	View	1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

some of these edits can use more cleaning up afterwards. I'm sending it out in ...

8 years, 4 months ago (2012-08-04 01:46:36 UTC) #1

vsm

lgtm https://chromiumcodereview.appspot.com/10832149/diff/1001/tools/get_archive.py File tools/get_archive.py (right): https://chromiumcodereview.appspot.com/10832149/diff/1001/tools/get_archive.py#newcode139 tools/get_archive.py:139: def latest_func(out, osname, revision_num): Consider renaming from "latest" ...

8 years, 4 months ago (2012-08-04 15:27:15 UTC) #2

Emily Fortuna

8 years, 4 months ago (2012-08-04 20:36:51 UTC) #3

https://chromiumcodereview.appspot.com/10832149/diff/1001/tools/get_archive.py
File tools/get_archive.py (right):

https://chromiumcodereview.appspot.com/10832149/diff/1001/tools/get_archive.p...
tools/get_archive.py:139: def latest_func(out, osname, revision_num):
On 2012/08/04 15:27:15, vsm wrote:
> Consider renaming from "latest" now that it gets a revision.

Done.

Expand Messages | Collapse Messages