Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10831406: Make ClassNode visit type parameters in visitChildren (Closed)

Created:
8 years, 4 months ago by Roman
Modified:
8 years, 4 months ago
Reviewers:
Anton Muhin, messick, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make ClassNode visit type parameters in visitChildren Committed: https://code.google.com/p/dart/source/detail?r=11057

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M lib/compiler/implementation/tree/nodes.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 2 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roman
https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart File lib/compiler/implementation/tree/nodes.dart (right): https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart#newcode209 lib/compiler/implementation/tree/nodes.dart:209: if (typeParameters !== null) typeParameters.accept(visitor); could there be any ...
8 years, 4 months ago (2012-08-21 14:36:37 UTC) #1
ahe
The test is great, but please coordinate with messick. https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart File lib/compiler/implementation/tree/nodes.dart (right): https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart#newcode209 lib/compiler/implementation/tree/nodes.dart:209: ...
8 years, 4 months ago (2012-08-21 14:45:27 UTC) #2
Anton Muhin
lgtm
8 years, 4 months ago (2012-08-21 14:46:26 UTC) #3
messick
https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart File lib/compiler/implementation/tree/nodes.dart (right): https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart#newcode209 lib/compiler/implementation/tree/nodes.dart:209: if (typeParameters !== null) typeParameters.accept(visitor); On 2012/08/21 14:45:27, ahe ...
8 years, 4 months ago (2012-08-21 14:56:37 UTC) #4
Roman
https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart File lib/compiler/implementation/tree/nodes.dart (right): https://chromiumcodereview.appspot.com/10831406/diff/1/lib/compiler/implementation/tree/nodes.dart#newcode209 lib/compiler/implementation/tree/nodes.dart:209: if (typeParameters !== null) typeParameters.accept(visitor); On 2012/08/21 14:56:37, messick ...
8 years, 4 months ago (2012-08-21 15:00:17 UTC) #5
ahe
8 years, 4 months ago (2012-08-21 15:02:26 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698