Issue 10831392: If an instruction is known to already by a number, the integer check will try to make it an integer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831392: If an instruction is known to already by a number, the integer check will try to make it an integer. (Closed)

Created:
8 years, 4 months ago by ngeoffray

Modified:
8 years, 4 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

If an instruction is known to already by a number, the integer check will try to make it an integer. Committed: https://code.google.com/p/dart/source/detail?r=11014

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
M	lib/compiler/implementation/ssa/bailout.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/dart2js.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/type_inference2_test.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/compiler/dart2js/type_inference4_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://chromiumcodereview.appspot.com/10831392/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10831392/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode1125 lib/compiler/implementation/ssa/nodes.dart:1125: if (input.isNumber(types)) return HType.INTEGER; Maybe rewrite using ?:

8 years, 4 months ago (2012-08-21 05:36:00 UTC) #2

ngeoffray

8 years, 4 months ago (2012-08-21 07:38:41 UTC) #3

Thanks Kasper

https://chromiumcodereview.appspot.com/10831392/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10831392/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:1125: if (input.isNumber(types))
return HType.INTEGER;
On 2012/08/21 05:36:00, kasperl wrote:
> Maybe rewrite using ?:

Done.

Expand Messages | Collapse Messages

Issue 10831392: If an instruction is known to already by a number, the integer check will try to make it an integer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages