Issue 10831371: Move args from lib/ to pkg/ .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831371: Move args from lib/ to pkg/ . (Closed)

Created:
8 years, 4 months ago by dgrove

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1595 lines)			Patch
D	lib/args/args.dart	View	1	1 chunk	+0 lines, -772 lines	0 comments	Download
D	lib/args/example.dart	View	1	1 chunk	+0 lines, -131 lines	0 comments	Download
D	lib/args/utils.dart	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download
M +	pkg/args/test/args_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
D	tests/lib/args/args_test.dart	View	1	1 chunk	+0 lines, -666 lines	0 comments	Download
M	tools/create_sdk.py	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	utils/pub/pub.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Bob Nystrom

8 years, 4 months ago (2012-08-17 16:06:58 UTC) #2

LGTM! You might want to check with Gram. I know he's been touching args lately
too and you may be moving code out from under him.