Issue 10831332: Support new getter syntax.

Issue 10831332: Support new getter syntax. (Closed)

Created:
8 years, 4 months ago by ahe

Modified:
8 years, 4 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Support new getter syntax. Committed: https://code.google.com/p/dart/source/detail?r=10956

Patch Set 2 : Address review comments and disable one test. #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -104 lines)			Patch
M	dart/lib/compiler/implementation/elements/elements.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/lib/native_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/resolver.dart	View	1	2 chunks	+28 lines, -6 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/listener.dart	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/parser.dart	View	1	6 chunks	+15 lines, -5 lines	0 comments	Download
M	dart/lib/compiler/implementation/warnings.dart	View		2 chunks	+8 lines, -2 lines	2 comments	Download
M	dart/tests/compiler/dart2js/unparser_test.dart	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/closure6_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_extra/closure7_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/getters_setters_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/naming_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/regress/4434_lib.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_native/native_class_avoids_hidden_name_frog_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_native/native_class_inheritance4_frog_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_native/native_class_with_dart_methods_frog_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_native/native_exceptions1_frog_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/language_dart2js.status	View		3 chunks	+3 lines, -66 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://chromiumcodereview.appspot.com/10831332/diff/5002/dart/lib/compiler/implementation/resolver.dart File dart/lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10831332/diff/5002/dart/lib/compiler/implementation/resolver.dart#newcode996 dart/lib/compiler/implementation/resolver.dart:996: ? const EmptyLink<Node>() : node.parameters.nodes; 4 space indent ...

8 years, 4 months ago (2012-08-20 12:55:31 UTC) #2

ahe

Thank you, Kasper. Notice I had to disable a part of unparser_test.dart. See http://dartbug.com/4604 https://chromiumcodereview.appspot.com/10831332/diff/5002/dart/lib/compiler/implementation/resolver.dart ...

8 years, 4 months ago (2012-08-20 13:26:17 UTC) #3

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10831332/diff/6035/dart/lib/compiler/implementation/warnings.dart File dart/lib/compiler/implementation/warnings.dart (left): https://chromiumcodereview.appspot.com/10831332/diff/6035/dart/lib/compiler/implementation/warnings.dart#oldcode240 dart/lib/compiler/implementation/warnings.dart:240: Message message([List<Type> arguments = const <Type>[]]) { Why ...

8 years, 4 months ago (2012-08-20 14:17:41 UTC) #4

ahe

8 years, 4 months ago (2012-08-20 14:39:02 UTC) #5

https://chromiumcodereview.appspot.com/10831332/diff/6035/dart/lib/compiler/i...
File dart/lib/compiler/implementation/warnings.dart (left):

https://chromiumcodereview.appspot.com/10831332/diff/6035/dart/lib/compiler/i...
dart/lib/compiler/implementation/warnings.dart:240: Message message([List<Type>
arguments = const <Type>[]]) {
On 2012/08/20 14:17:41, ngeoffray wrote:
> Why this change?

It was a bad cut-and-paste originally.

Expand Messages | Collapse Messages