Issue 10831327: Update stopwatch to use patching to share sources instead of exposing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831327: Update stopwatch to use patching to share sources instead of exposing (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Update stopwatch to use patching to share sources instead of exposing a Clock class. R=lrn@google.com,ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10715

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -85 lines)			Patch
M	corelib/src/implementation/stopwatch_implementation.dart	View	5 chunks	+9 lines, -9 lines	0 comments	Download
D	lib/compiler/implementation/lib/clock.dart	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	lib/compiler/implementation/lib/core.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View	2 chunks	+13 lines, -1 line	0 comments	Download
D	runtime/lib/clock.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	runtime/lib/clock.dart	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1 chunk	+1 line, -2 lines	0 comments	Download
A +	runtime/lib/stopwatch.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A	runtime/lib/stopwatch_patch.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM, very nice!