Issue 10831324: Cleanup of math sources.

Issue 10831324: Cleanup of math sources. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup of math sources. Get rid of temporary unified directory version. Move back into lib/math where it should be. Rename patch files from the for math.dartp to the form math_patch.dart. They are just dart files and I don't like the new dartp extension. R=ajohnsen@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10709

Patch Set 1 #

Total comments: 3

Patch Set 2 : Attempt to fix upload #

Patch Set 3 : Another attempt #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -462 lines)			Patch
D	corelib/unified/math/base.dart	View		1 chunk	+0 lines, -151 lines	0 comments	Download
D	corelib/unified/math/math.dart	View		1 chunk	+0 lines, -8 lines	0 comments	Download
D	corelib/unified/math/math_sources.gypi	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	corelib/unified/math/random.dart	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	lib/compiler/implementation/lib/coreimpl.dartp	View		1 chunk	+0 lines, -53 lines	0 comments	Download
A +	lib/compiler/implementation/lib/coreimpl_patch.dart	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/compiler/implementation/lib/math.dartp	View		1 chunk	+0 lines, -105 lines	0 comments	Download
A +	lib/compiler/implementation/lib/math_patch.dart	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/compiler/implementation/library_map.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/math/base.dart	View		3 chunks	+16 lines, -15 lines	0 comments	Download
M	lib/math/math.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	lib/math/math_sources.gypi	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/math/random.dart	View		1 chunk	+9 lines, -78 lines	0 comments	Download
M	runtime/vm/vm.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

Argh, I lost some of the changes here. I'll ping when ready for review.

8 years, 4 months ago (2012-08-15 11:00:34 UTC) #2

Mads Ager (google)

OK, that was weird. I think everything is in place now. Please have a look.

8 years, 4 months ago (2012-08-15 11:18:18 UTC) #3

Anders Johnsen

LGTM https://chromiumcodereview.appspot.com/10831324/diff/1/lib/compiler/implementation/library_map.dart File lib/compiler/implementation/library_map.dart (right): https://chromiumcodereview.appspot.com/10831324/diff/1/lib/compiler/implementation/library_map.dart#newcode50 lib/compiler/implementation/library_map.dart:50: "lib/math/math.dart", YES! https://chromiumcodereview.appspot.com/10831324/diff/1/lib/math/base.dart File lib/math/base.dart (right): https://chromiumcodereview.appspot.com/10831324/diff/1/lib/math/base.dart#newcode84 lib/math/base.dart:84: ...

8 years, 4 months ago (2012-08-15 11:23:23 UTC) #4

Mads Ager (google)

8 years, 4 months ago (2012-08-15 11:24:48 UTC) #5

https://chromiumcodereview.appspot.com/10831324/diff/1/lib/math/base.dart
File lib/math/base.dart (right):

https://chromiumcodereview.appspot.com/10831324/diff/1/lib/math/base.dart#new...
lib/math/base.dart:84: if (a == 0 && b.isNegative() || b.isNaN()) return b;
On 2012/08/15 11:23:23, ajohnsen wrote:
> Nice catch, Editor?

Nope, but I copied the file where it was correct. :)

Expand Messages | Collapse Messages