Issue 10831301: - Use the unified dart:math library in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831301: - Use the unified dart:math library in the VM. (Closed)

Created:
8 years, 4 months ago by Ivan Posva

Modified:
8 years, 4 months ago

Reviewers:
Anders Johnsen, Mads Ager (google), siva

CC:
reviews_dartlang.org, hausner

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Use the unified dart:math library in the VM. Committed: https://code.google.com/p/dart/source/detail?r=10698

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -12 lines)			Patch
A +	corelib/unified/math/math_sources.gypi	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/math/math_sources.gypi	View	1 chunk	+0 lines, -10 lines	0 comments	Download
A	runtime/lib/math_patch.dart	View	1 chunk	+102 lines, -0 lines	0 comments	Download
M	runtime/lib/math_sources.gypi	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	runtime/vm/vm.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

This is an example on how to use patch sources in the VM. -Ivan

8 years, 4 months ago (2012-08-14 01:54:09 UTC) #1

Mads Ager (google)

LGTM! https://chromiumcodereview.appspot.com/10831301/diff/1/runtime/lib/math_sources.gypi File runtime/lib/math_sources.gypi (left): https://chromiumcodereview.appspot.com/10831301/diff/1/runtime/lib/math_sources.gypi#oldcode7 runtime/lib/math_sources.gypi:7: 'empty_source.dart', Let's delete empty_source.dart from the repo?

8 years, 4 months ago (2012-08-14 07:13:30 UTC) #2

Ivan Posva

8 years, 4 months ago (2012-08-15 04:49:58 UTC) #4

https://chromiumcodereview.appspot.com/10831301/diff/1/runtime/lib/math_sourc...
File runtime/lib/math_sources.gypi (left):

https://chromiumcodereview.appspot.com/10831301/diff/1/runtime/lib/math_sourc...
runtime/lib/math_sources.gypi:7: 'empty_source.dart',
On 2012/08/14 07:13:30, Mads Ager wrote:
> Let's delete empty_source.dart from the repo?

As far as I know there are still other gypi files that refer to this (e.g.
isolate and mirrors).

Expand Messages | Collapse Messages