Issue 10831285: Revert "Register toString dynamic invocation in the presence of string interpolation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831285: Revert "Register toString dynamic invocation in the presence of string interpolation." (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Register toString dynamic invocation in the presence of string interpolation." This reverts commit e3bc84ade08c6c9acedfd1ad7e1f159832e0b4a1. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=10585

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -27 lines)			Patch
M	lib/compiler/implementation/resolver.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/call_site_type_inferer_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_helper.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/concrete_type_inference_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View	3 chunks	+0 lines, -19 lines	0 comments	Download
M	tests/language/language.status	View	3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 4 months ago (2012-08-13 16:40:41 UTC) #2

LGTM. Looks like a missing import. Take a look at:

http://code.google.com/p/dart/wiki/TestingDart2js#Basic_test_recommendation

The first line is what I recommend for running the unit tests. Notice that we
use --checked argument to test.py.

Expand Messages | Collapse Messages