Issue 10831262: Revert "Revert "Allow patch files to add top-level declarations to the patched library.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831262: Revert "Revert "Allow patch files to add top-level declarations to the patched library."" (Closed)

Created:
8 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 4 months ago

Reviewers:
ahe, Anders Johnsen, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow patch files to add declarations to the patched library. Committed: https://code.google.com/p/dart/source/detail?r=10562

Patch Set 1 #

Patch Set 2 : Fixed bugs #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -75 lines)			Patch
M	corelib/unified/math/base.dart	View		1 chunk	+65 lines, -10 lines	0 comments	Download
M	corelib/unified/math/random.dart	View		3 chunks	+5 lines, -12 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1	6 chunks	+12 lines, -10 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	25 chunks	+163 lines, -24 lines	0 comments	Download
M	lib/compiler/implementation/lib/math.dartp	View		3 chunks	+17 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/patch_parser.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/scanner/class_element_parser.dart	View	1	3 chunks	+13 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1	3 chunks	+24 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/unparse_validator.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Now fully functional. Anders, please check if the bugs you found were fixed.

8 years, 4 months ago (2012-08-13 10:49:48 UTC) #2

ahe

8 years, 4 months ago (2012-08-13 12:28:45 UTC) #5

I'd like to see the dart2js and library changes made in separate CLs.

I'd like to see unit tests for the patch code.

I'd like to see the patch code moved out of compiler.dart.

Expand Messages | Collapse Messages