Issue 10831176: Make CreateArrayComp a call by using explicit push-argument instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831176: Make CreateArrayComp a call by using explicit push-argument instructions. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Make CreateArrayComp a call by using explicit push-argument instructions. This enables SSA compilation of functions containing CreateArray. Currently, we don't support call-instructions that have pushed arguments and also take input operands in registers. This will be done in a separate CL. Committed: https://code.google.com/p/dart/source/detail?r=10284

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -73 lines)			Patch
M	vm/flow_graph_builder.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	vm/intermediate_language.h	View	3 chunks	+6 lines, -8 lines	2 comments	Download
M	vm/intermediate_language.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	vm/intermediate_language_ia32.cc	View	1 chunk	+7 lines, -21 lines	0 comments	Download
M	vm/intermediate_language_x64.cc	View	1 chunk	+7 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://chromiumcodereview.appspot.com/10831176/diff/1/vm/intermediate_language.h File vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10831176/diff/1/vm/intermediate_language.h#newcode1196 vm/intermediate_language.h:1196: #endif This CL causes crashes as element_type is never ...

8 years, 4 months ago (2012-08-06 16:31:25 UTC) #3

Florian Schneider

8 years, 4 months ago (2012-08-07 08:56:18 UTC) #4

https://chromiumcodereview.appspot.com/10831176/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10831176/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:1196: #endif
On 2012/08/06 16:31:25, srdjan wrote:
> This CL causes crashes as element_type is never set

Oh, thanks. It worked because elements_type_ seems to be used only in
IL-printing. I have a CL that fixes this instruction (i.e. makes it a
TemplateComputation again, but make sure it is handled as a call so that SSA
code generation supports it)

Expand Messages | Collapse Messages