Issue 10831154: Make field-get/set work without elements.

Issue 10831154: Make field-get/set work without elements. (Closed)

Created:
8 years, 4 months ago by floitsch

Modified:
8 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make field-get/set work without elements. Committed: https://code.google.com/p/dart/source/detail?r=10334

Patch Set 2 : Addressed comments. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -53 lines)			Patch
M	lib/compiler/implementation/elements/elements.dart	View	1	2 chunks	+31 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/emitter.dart	View	1	5 chunks	+17 lines, -23 lines	0 comments	Download
M	lib/compiler/implementation/namer.dart	View	1	2 chunks	+13 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1	4 chunks	+31 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implementation/emitter.dart File lib/compiler/implementation/emitter.dart (right): https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implementation/emitter.dart#newcode472 lib/compiler/implementation/emitter.dart:472: String fieldName; Maybe use ?: here? https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implementation/ssa/nodes.dart File ...

8 years, 4 months ago (2012-08-07 08:14:20 UTC) #2

floitsch

8 years, 4 months ago (2012-08-07 12:20:16 UTC) #3

https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:472: String fieldName;
On 2012/08/07 08:14:20, kasperl wrote:
> Maybe use ?: here?

Done.

https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10831154/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:1312: final LibraryElement
libraryElement;
On 2012/08/07 08:14:20, kasperl wrote:
> Maybe shorten this to library?

Done.

Expand Messages | Collapse Messages