Issue 10831131: Dart textmate bundle updates (support for 'external' and 'as').

Issue 10831131: Dart textmate bundle updates (support for 'external' and 'as'). (Closed)

Created:
8 years, 4 months ago by pquitslund

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, austincummings95_gmail.com

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Dart textmate bundle updates (support for 'external' and 'as'). Committed: https://code.google.com/p/dart/source/detail?r=10188

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.tmLanguage	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	tools/utils/textmate/README	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Nits, but LGTM! https://chromiumcodereview.appspot.com/10831131/diff/1/tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate File tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate (right): https://chromiumcodereview.appspot.com/10831131/diff/1/tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate#newcode64 tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate:64: match = '\b(as)\b'; Don't need the ...

8 years, 4 months ago (2012-08-02 18:00:25 UTC) #2

pquitslund

8 years, 4 months ago (2012-08-02 18:19:06 UTC) #3

Thanks Bob!

https://chromiumcodereview.appspot.com/10831131/diff/1/tools/utils/textmate/D...
File tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate (right):

https://chromiumcodereview.appspot.com/10831131/diff/1/tools/utils/textmate/D...
tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate:64: match =
'\b(as)\b';
On 2012/08/02 18:00:26, Bob Nystrom wrote:
> Don't need the parentheses since there's just one here.

Right.  Fixed!

https://chromiumcodereview.appspot.com/10831131/diff/1/tools/utils/textmate/D...
tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate:109: match =
'\b(static|final|native|abstract|const|class|interface|get|set|operator|external)\b';
On 2012/08/02 18:00:26, Bob Nystrom wrote:
> Should "patch" go in here too?

Hmmm...  I think that's a dartp-ism and I'm not willing to go there quite yet
since we know not what the format of dartp files will ultimately be.  In the
long run we should have a story.  In the short run, let's leave it as an
exercise for the reader ;).

Expand Messages | Collapse Messages