Issue 10831036: More radical variant of refactor conversion to native.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831036: More radical variant of refactor conversion to native. (Closed)

Created:
8 years, 5 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

More radical variant of refactor conversion to native. Committed: https://code.google.com/p/dart/source/detail?r=11233

Patch Set 4 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -24 lines)			Patch
	M	lib/dom/scripts/generator.py	View	1 2 3	2 chunks	+10 lines, -17 lines	0 comments	Download
	M	lib/dom/scripts/systemnative.py	View	1 2 3	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/generator.py#newcode477 lib/dom/scripts/generator.py:477: argument_template = '%s.get()' argument_expression_template? https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): ...

8 years, 4 months ago (2012-08-23 08:18:04 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-08-23 15:04:12 UTC) #3

Thanks a lot for review, submitting.

https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/gen...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/gen...
lib/dom/scripts/generator.py:477: argument_template = '%s.get()'
On 2012/08/23 08:18:04, podivilov wrote:
> argument_expression_template?

Done.

https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/sys...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10831036/diff/4001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:833: argument_template, type, cls, function = \
On 2012/08/23 08:18:04, podivilov wrote:
> ditto

Done.

Expand Messages | Collapse Messages

Issue 10831036: More radical variant of refactor conversion to native. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages